[HUDI-6240] Adding default value as CORRECTED for rebase modes in write and read for avro #8764
+13
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nsivabalan
added
release-0.14.0
priority:critical
yihua
reviewed
May 19, 2023
| @@ -54,7 +54,7 @@ private[sql] class AvroSerializer(rootCatalystType: DataType, | |||
| def this(rootCatalystType: DataType, rootAvroType: Schema, nullable: Boolean) = { | |||
| this(rootCatalystType, rootAvroType, nullable, | |||
| LegacyBehaviorPolicy.withName(SQLConf.get.getConf( | |||
| SQLConf.LEGACY_AVRO_REBASE_MODE_IN_WRITE))) | |||
| SQLConf.LEGACY_AVRO_REBASE_MODE_IN_WRITE, "CORRECTED"))) | |||
There was a problem hiding this comment.
nit: CORRECTED to static final variable?
There was a problem hiding this comment.
fixed using LegacyBehaviorPolicy.CORRECTED.toString
xushiyan
approved these changes
May 20, 2023
4 tasks
vinishjail97
pushed a commit
to vinishjail97/hudi
that referenced
this pull request
Dec 15, 2023
…te and read for avro (apache#8764) (apache#294) Co-authored-by: Sivabalan Narayanan <n.siva.b@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Logs
Adding default value as "CORRECTED" for rebase modes in write and read for avro, to be used when encountering timestamps older than 1970.
Impact
Will automatically work out of the box, unless user prefers to override them.
Risk level (write none, low medium or high below)
low.
Documentation Update
Describe any necessary documentation update if there is any new feature, config, or user-facing change
ticket number here and follow the instruction to make
changes to the website.
Contributor's checklist