Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HUDI-6542] Fix ExpressionEvaluators doesnt support BIGINT #9215

Conversation

Alowator
Copy link
Contributor

@Alowator Alowator commented Jul 17, 2023

Change Logs

Add support of BIGINT type in ExpressionEvaluators

Impact

Bug fix

Risk level (write none, low medium or high below)

none

Documentation Update

No needed

Contributor's checklist

  • Read through contributor's guide
  • Change Logs and Impact were stated clearly
  • Adequate tests were added if applicable
  • CI passed

@Alowator
Copy link
Contributor Author

@danny0405 the same as #9112

@Alowator Alowator force-pushed the hudi-6542-Fix-ExpressionEvaluators-doesnt-support-BIGINT branch from 667b0b5 to 94ddd4f Compare July 17, 2023 12:08
public static final DataType DATA_TYPE_BIGINT_PK = DataTypes.ROW(
DataTypes.FIELD("uuid", DataTypes.BIGINT()),
DataTypes.FIELD("name", DataTypes.VARCHAR(10)),
DataTypes.FIELD("age", DataTypes.INT()),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we move the data types to TestConfigurations

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moved

@danny0405 danny0405 self-assigned this Jul 18, 2023
@danny0405 danny0405 added flink Issues related to flink schema-and-data-types labels Jul 18, 2023
@Alowator Alowator force-pushed the hudi-6542-Fix-ExpressionEvaluators-doesnt-support-BIGINT branch from 94ddd4f to af80667 Compare July 18, 2023 05:55
@Alowator Alowator force-pushed the hudi-6542-Fix-ExpressionEvaluators-doesnt-support-BIGINT branch from af80667 to c235bc0 Compare July 18, 2023 06:10
@Alowator Alowator requested a review from danny0405 July 18, 2023 10:17
@Alowator
Copy link
Contributor Author

@hudi-bot run azure

@hudi-bot
Copy link

CI report:

Bot commands @hudi-bot supports the following commands:
  • @hudi-bot run azure re-run the last Azure build

@Alowator
Copy link
Contributor Author

@danny0405 if there are no any questions it could be merged

@danny0405 danny0405 merged commit f6c947c into apache:master Jul 19, 2023
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flink Issues related to flink schema-and-data-types
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants