Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[HUDI-6651] Support IN SQL query with Record Index #9373

Merged
merged 3 commits into from
Aug 7, 2023
Merged

[HUDI-6651] Support IN SQL query with Record Index #9373

merged 3 commits into from
Aug 7, 2023

Conversation

lokeshj1703
Copy link
Contributor

Change Logs

Currently Record Index based pruning is only supported for EqualTo queries on a record key. This Jira aims to add support for IN query as well.

Impact

SQL queries with IN predicate on record key will be faster.

Risk level (write none, low medium or high below)

low

Documentation Update

NA

Contributor's checklist

  • Read through contributor's guide
  • Change Logs and Impact were stated clearly
  • Adequate tests were added if applicable
  • CI passed

codope
codope reviewed Aug 5, 2023
View reviewed changes
Copy link
Member

@codope codope left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding IN support. Looks good to me. Few test related comments.

...ource/hudi-spark/src/test/scala/org/apache/hudi/functional/TestRecordLevelIndexWithSQL.scala Show resolved Hide resolved
nsivabalan
nsivabalan reviewed Aug 5, 2023
View reviewed changes
Copy link
Contributor

@nsivabalan nsivabalan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mostly minor comments

...rk-datasource/hudi-spark-common/src/main/scala/org/apache/hudi/RecordLevelIndexSupport.scala Show resolved Hide resolved
...ource/hudi-spark/src/test/scala/org/apache/hudi/functional/TestRecordLevelIndexWithSQL.scala Show resolved Hide resolved
...ource/hudi-spark/src/test/scala/org/apache/hudi/functional/TestRecordLevelIndexWithSQL.scala Outdated Show resolved Hide resolved
@hudi-bot
Copy link

hudi-bot commented Aug 6, 2023

CI report:

Bot commands @hudi-bot supports the following commands:
  • @hudi-bot run azure re-run the last Azure build

@codope codope merged commit bf09668 into apache:master Aug 7, 2023
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nsivabalan nsivabalan nsivabalan approved these changes

@codope codope codope approved these changes

Assignees
No one assigned
Labels
index priority:blocker release-0.14.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@lokeshj1703 @hudi-bot @nsivabalan @codope