[HUDI-6728] Update BigQuery manifest sync to support schema evolution #9482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if (definition.getSchema() != null && definition.getSchema().equals(finalSchema)) { | ||
| return; // No need to update schema. | ||
| } | ||
| Table updatedTable = existingTable.toBuilder() |
There was a problem hiding this comment.
Clarification: We are creating the table by providing a schema without partition fields, but updating it with the schema by adding the partition fields, are we sure it's the right thing ? Without manifests and using ExternalTableDefinition, we use the schema without partition fields.
There was a problem hiding this comment.
Yes, when updating the schema, BigQuery expects all fields including the partition fields to be present.
There was a problem hiding this comment.
can you add java docs around this in lines 163 ish.
rmahindra123
approved these changes
Aug 24, 2023
hudi-gcp/src/main/java/org/apache/hudi/gcp/bigquery/BigQuerySyncTool.java
Outdated
Show resolved
Hide resolved
nsivabalan
reviewed
Aug 26, 2023
hudi-gcp/src/main/java/org/apache/hudi/gcp/bigquery/BigQuerySyncTool.java
Show resolved
Hide resolved
hudi-gcp/src/main/java/org/apache/hudi/gcp/bigquery/BigQuerySyncTool.java
Outdated
Show resolved
Hide resolved
| if (definition.getSchema() != null && definition.getSchema().equals(finalSchema)) { | ||
| return; // No need to update schema. | ||
| } | ||
| Table updatedTable = existingTable.toBuilder() |
There was a problem hiding this comment.
can you add java docs around this in lines 163 ish.
nsivabalan
approved these changes
Aug 31, 2023
hudi-gcp/src/main/java/org/apache/hudi/gcp/bigquery/BigQuerySyncTool.java
Outdated
Show resolved
Hide resolved
hudi-gcp/src/main/java/org/apache/hudi/gcp/bigquery/BigQuerySyncTool.java
Outdated
Show resolved
Hide resolved
|
@hudi-bot run azure |
nsivabalan
force-pushed
the
bigquery-schema-support
branch
from
bd99a6c
to
51c9a62
Compare
|
@hudi-bot run azure |
prashantwason
pushed a commit
that referenced
this pull request
Sep 13, 2023
leosanqing
pushed a commit
to leosanqing/hudi
that referenced
this pull request
Sep 13, 2023
…apache#9482) Adds schema evolution support to the BigQuerySyncTool by converting the Hudi schema into the BigQuery Schema format when creating and updating the table.
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Logs
Adds schema evolution support to the BigQuerySyncTool by converting the Hudi schema into the BigQuery Schema format when creating and updating the table.
Impact
Ensures users can properly query their tables even after updating the schema of the tables.
Risk level (write none, low medium or high below)
Low, this only impacts users of the new manifest-style table in BigQuery
Documentation Update
Describe any necessary documentation update if there is any new feature, config, or user-facing change
ticket number here and follow the instruction to make
changes to the website.
Contributor's checklist