[HUDI-6924] Fix hoodie table config not wok in table properties #9836
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@boneanxs Do you have intreast to review this PR? |
boneanxs
reviewed
Oct 11, 2023
| @@ -199,7 +184,7 @@ object HoodieOptionConfig { | |||
|
|
|||
| // extract primaryKey, preCombineField, type options | |||
| def extractSqlOptions(options: Map[String, String]): Map[String, String] = { | |||
| val sqlOptions = mapTableConfigsToSqlOptions(options) | |||
| val sqlOptions = mapHoodieOptionsToSqlOptions(options) | |||
There was a problem hiding this comment.
mapHoodieConfigsToSqlOptions should be more accurate?
| * @param options | ||
| * @return | ||
| */ | ||
| def getTableType(options: Map[String, String]): String = { |
boneanxs
approved these changes
Oct 13, 2023
There was a problem hiding this comment.
+1 for this, this is actually a bug that hoodie tableconfig won't take effect if user set it.
But we need to note that there's a behavior change if user both set writeConfig & tableConfig, before only writeConfigs take effect, but now tableConfig has priority than writeConfig(Thinking this should be minor since user usually won't set both).
|
@hudi-bot run azure |
danny0405
approved these changes
Oct 17, 2023
nsivabalan
pushed a commit
that referenced
this pull request
Nov 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Logs
Fix the bug that hoodie table config not work in table properties. Including:
mapTableConfigsToSqlOptionsandmapDataSourceWriteOptionsToSqlOptionstomapHoodieOptionsToSqlOptionsinHoodieOptionConfig.HoodieOptionConfig.Impact
Make
hoodie.table.*configs take effect.Risk level (write none, low medium or high below)
None.
Documentation Update
Describe any necessary documentation update if there is any new feature, config, or user-facing change
ticket number here and follow the instruction to make
changes to the website.
Contributor's checklist