Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: replace 'Builder' with 'TypedBuilder' for 'Snapshot' #110

Merged
merged 2 commits into from
Dec 3, 2023
Merged

feat: replace 'Builder' with 'TypedBuilder' for 'Snapshot' #110

merged 2 commits into from
Dec 3, 2023

Conversation

xiaoyang-sde
Copy link
Member

@xiaoyang-sde xiaoyang-sde commented Nov 28, 2023 •
edited by Fokko

@xiaoyang-sde xiaoyang-sde marked this pull request as ready for review November 28, 2023 06:20
liurenjie1024
liurenjie1024 approved these changes Nov 29, 2023
View reviewed changes
Copy link
Collaborator

@liurenjie1024 liurenjie1024 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM!

ZENOTME
ZENOTME approved these changes Nov 29, 2023
View reviewed changes
Copy link
Contributor

@ZENOTME ZENOTME left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@xiaoyang-sde
Copy link
Member Author

xiaoyang-sde commented Nov 30, 2023 •
edited

cc @Fokko

Could you please review this pull request when you have time?

Fokko
Fokko reviewed Dec 3, 2023
View reviewed changes
Copy link
Contributor

@Fokko Fokko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xiaoyang-sde Certainly! Thanks for working on this!

@liurenjie1024 @ZENOTME Thanks for the review

@Fokko Fokko merged commit e887fb1 into apache:main Dec 3, 2023
6 checks passed
@xiaoyang-sde xiaoyang-sde deleted the typed_builder_snapshot branch December 3, 2023 01:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fokko Fokko Fokko approved these changes

@liurenjie1024 liurenjie1024 liurenjie1024 approved these changes

@ZENOTME ZENOTME ZENOTME approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Discussion: Replace usage of Builder with TypedBuilder
4 participants
@xiaoyang-sde @Fokko @liurenjie1024 @ZENOTME