feat: init file writer interface #168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Xuanwo
reviewed
Jan 18, 2024
| /// The associated file writer type. | ||
| type R: FileWriter<O>; | ||
| /// Build file writer. | ||
| fn build(self) -> impl std::future::Future<Output = Result<Self::R>> + Send; |
There was a problem hiding this comment.
nit: How about using Future here for short?
| /// Write record batch to file. | ||
| fn write(&mut self, batch: &RecordBatch) -> impl std::future::Future<Output = Result<()>> + Send; | ||
| /// Close file writer. | ||
| fn close(self) -> impl std::future::Future<Output = Result<O>> + Send; |
| } | ||
|
|
||
| /// File writer focus on writing record batch to different physical file format.(Such as parquet. orc) | ||
| pub trait FileWriter<O = DefaultOutput>: Send + 'static + CurrentFileStatus { |
There was a problem hiding this comment.
nit: please place 'static at the end of this line.
Fokko
approved these changes
Jan 25, 2024
There was a problem hiding this comment.
Looks good! Thanks for working on this @ZENOTME and @liurenjie1024 @Xuanwo for the reviews 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related issue: #34
It's the part of #135.
The file writer interface is about the writer for data file format, e.g. parquet, orc.