feat: Bump hive_metastore to use pure rust thrift impl volo
#174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| .address(address) | ||
| // Framed thrift rpc is not enabled by default in HMS, we use | ||
| // buffered instead. | ||
| .make_codec(volo_thrift::codec::default::DefaultMakeCodec::buffered()) |
There was a problem hiding this comment.
Maybe it's better to make this a config?
There was a problem hiding this comment.
I agree we should make this setting available to users, though I believe it's a lower priority. I've created an issue at #188 to keep track of this.
| } | ||
|
|
||
| /// Format an io error into iceberg error. | ||
| pub fn from_io_error(error: io::Error) -> Error { |
There was a problem hiding this comment.
io::Error is a common error, how about moving it to core crate?
There was a problem hiding this comment.
I'm not sure if moving to core and making it a public API is a good idea. What if we address this once we have the same from_io_error in core?
This was referenced Feb 1, 2024
|
cc @Xuanwo Any updates? |
|
cc @liurenjie1024, please review again. Sorry for the late. |
liurenjie1024
approved these changes
Feb 5, 2024
Fokko
approved these changes
Feb 5, 2024
There was a problem hiding this comment.
Thanks for the PR @Xuanwo and @liurenjie1024 for the review 🙌
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #155