feat: add handwritten serialize #185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZENOTME
reviewed
Feb 4, 2024
| TableMetadataV1 { | ||
| impl TryFrom<TableMetadata> for TableMetadataV1 { | ||
| type Error = Error; | ||
| fn try_from(v: TableMetadata) -> Result<Self, Error> { |
There was a problem hiding this comment.
If we still use expect at following, why we need to convert it to try_from🤔
There was a problem hiding this comment.
Well, cuz I want make 2 separate PRs -- 1 for serialize and 1 for removing expect . I should really mention it before.
|
Replaced |
Fokko
approved these changes
Feb 5, 2024
There was a problem hiding this comment.
Thanks @odysa for raising this PR, and thanks @liurenjie1024 for the prompt review 🙌
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add serialize for
TableMetadataand useTryFromas discussed in #177