refactor: Align data type with other implementation. #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JanKaul
reviewed
Aug 4, 2023
Comment on lines
+95
to
+114
| impl Serialize for Type { | ||
| fn serialize<S>(&self, serializer: S) -> Result<S::Ok, S::Error> | ||
| where | ||
| S: Serializer, | ||
| { | ||
| let type_serde = _serde::SerdeType::from(self); | ||
| type_serde.serialize(serializer) | ||
| } | ||
| } | ||
|
|
||
| impl<'de> Deserialize<'de> for Type { | ||
| fn deserialize<D>(deserializer: D) -> Result<Self, D::Error> | ||
| where | ||
| D: Deserializer<'de>, | ||
| { | ||
| let type_serde = _serde::SerdeType::deserialize(deserializer)?; | ||
| Ok(Type::from(type_serde)) | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
Couldn't we simplify this with:
#[serde(from = "_serde::SerdeType", into = "_serde::SerdeType")]
pub enum Type {
...
}There was a problem hiding this comment.
I tried, but it seems that the generated code can't contains lifetime parameter. The code duplication is not much, so I prefer to keep current approach.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This refactor introduces two changes:
NestedFieldin composite types such as struct, map, list to align with java/python implementation.