Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update github configuration to avoid conflicting merge #31

Merged
merged 1 commit into from
Aug 15, 2023

Conversation

liurenjie1024
Copy link
Collaborator

Recently we see conflicting merge, and we add this check in github setting to avoid it.

@liurenjie1024
Copy link
Collaborator Author

cc @JanKaul @Xuanwo @Fokko PTAL

@liurenjie1024
Copy link
Collaborator Author

The failure is fixed by #30 , we can fix it after #30

Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool!

Copy link
Collaborator

@JanKaul JanKaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@Fokko
Copy link
Contributor

Fokko commented Aug 15, 2023

I like this!

@liurenjie1024 Can you rebase?

@liurenjie1024
Copy link
Collaborator Author

I like this!

@liurenjie1024 Can you rebase?

Yes, done.

@Fokko Fokko merged commit 2ce9bf5 into apache:main Aug 15, 2023
7 checks passed
@Fokko
Copy link
Contributor

Fokko commented Aug 15, 2023

Thanks @liurenjie1024, and thank for the review @JanKaul & @Xuanwo

@liurenjie1024 liurenjie1024 deleted the renjie/update-asf branch August 15, 2023 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants