Implement BoundPredicateVisitor trait for ManifestFilterVisitor #367
Conversation
|
@sdd, thank you for reviewing the changes and providing references! I have modified my code based on your suggestions. Please take a look and let me know if I miss anything. |
| return ROWS_MIGHT_MATCH; | ||
| } | ||
|
|
||
| if let Some(Literal::Primitive(lower_bound)) = &field.lower_bound { |
There was a problem hiding this comment.
This is much cleaner! Thanks :-)
There was a problem hiding this comment.
Thanks for this PR @s-akhtar-baig which looks really good - left some minor comments. However, please check the comment about 'comparison' and the and implementation and verify its correct.
There was a problem hiding this comment.
@marvinlanhenke @sdd, thank you for reviewing. I have modified the code accordingly and added comments for clarification. Let me know what you think.
There was a problem hiding this comment.
Thanks @s-akhtar-baig for this great pr, it looks great! I left some questions about the confusing part. Also I think one important thing is that we should not rely one the Ord of PrimitiveLiteral.
There was a problem hiding this comment.
Thanks @s-akhtar-baig for this pr, it's great! There are some changes since #378 got resolved, so please rebase main branch to fix it. Others LGTM, thanks for this effort!
|
@liurenjie1024 @marvinlanhenke @sdd, thank you for reviewing these changes and for your feedback! Greatly appreciated! I have pushed the required changes. Please let me know if I missed anything, thanks! |
|
Hi @liurenjie1024 - sorry to pester you but are you able to re-review this please? It's the last major piece of the puzzle on the read side. |
There was a problem hiding this comment.
@s-akhtar-baig
LGTM. Thanks for your effort here, just a minor nit that is still unresolved from the last review about extracting a common helper function, but this is not a blocker.
Hi, @sdd Sorry for delay. I'll review it today. |
|
cc @Fokko Do you want to take a review for this? I see you assigned yourself for review. |
There was a problem hiding this comment.
Thanks @s-akhtar-baig for working on this, and adding all the tests 🙌 Thanks @marvinlanhenke, @sdd and @liurenjie1024 for the review!
GitHub issue: #350
Description: ManifestEvaluator was defined in #322. This PR implements all functions and adds most of the Python unit tests.
Testing: Added new unit tests.