Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Allow Schema Serialization/deserialization #46

Merged
merged 7 commits into from
Aug 31, 2023
Merged

feat: Allow Schema Serialization/deserialization #46

merged 7 commits into from
Aug 31, 2023

Conversation

y0psolo
Copy link
Contributor

@y0psolo y0psolo commented Aug 29, 2023

This change allow Schema Serialzation/Deserialization based on the into and try_from parameters for serde from a new enum regrouping SchemaV1 and SchemaV2 struct. I added also some helper for conversion between the enum and Schema struct.

The functionality is tested with a new test inside the test section

@y0psolo y0psolo changed the title Allow Schema Serialization/deserialization feat: Allow Schema Serialization/deserialization Aug 29, 2023
@y0psolo
Copy link
Contributor Author

y0psolo commented Aug 29, 2023

close #41

Add a test to ensure correct enum is choosen by ser/deser crate
Reuse existing table_schema_simple schema for test
Pretty indent of JSON Schema
Copy link
Contributor

@Fokko Fokko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense to me. I'll let others review as well before merging 👍🏻

Copy link
Collaborator

@liurenjie1024 liurenjie1024 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks!

@Fokko Fokko merged commit 7e46240 into apache:main Aug 31, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants