Serialization change accepted

apache · Nov 13, 2023 · 32d2645 · 32d2645
1 parent f6279d0
commit 32d2645
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 3 deletions.
diff --git a/.palantir/revapi.yml b/.palantir/revapi.yml
@@ -866,6 +866,11 @@ acceptedBreaks:
       old: "method void org.apache.iceberg.encryption.Ciphers::<init>()"
       new: "method void org.apache.iceberg.encryption.Ciphers::<init>()"
       justification: "Static utility class - should not have public constructor"
+  "1.4.0":
+    org.apache.iceberg:iceberg-core:
+    - code: "java.field.serialVersionUIDChanged"
+      new: "field org.apache.iceberg.util.SerializableMap<K, V>.serialVersionUID"
+      justification: "Serialization is not be used"
   apache-iceberg-0.14.0:
     org.apache.iceberg:iceberg-api:
     - code: "java.class.defaultSerializationChanged"

diff --git a/api/src/main/java/org/apache/iceberg/Scan.java b/api/src/main/java/org/apache/iceberg/Scan.java
@@ -83,8 +83,7 @@ public interface Scan<ThisT, T extends ScanTask, G extends ScanTaskGroup<T>> {
    *
    * <p>Column stats include: value count, null value count, lower bounds, and upper bounds.
    *
-   * @param requestedColumns column names for which to keep the stats. If <code>null</code> then all
-   *     column stats will be kept, when {@link #includeColumnStats()} is set.
+   * @param requestedColumns column names for which to keep the stats.
    * @return a new scan based on this that loads column stats for specific columns.
    */
   default ThisT includeColumnStats(Collection<String> requestedColumns) {

diff --git a/core/src/main/java/org/apache/iceberg/V2Metadata.java b/core/src/main/java/org/apache/iceberg/V2Metadata.java
@@ -563,7 +563,7 @@ public F copy() {
 
     @Override
     public F copyWithStats(Set<Integer> requestedColumnIds) {
-      return wrapped.copyWithStats(requestedColumnIds);
+      throw new UnsupportedOperationException("Cannot copy IndexedDataFile wrapper");
     }
 
     @Override

diff --git a/core/src/main/java/org/apache/iceberg/util/SerializableMap.java b/core/src/main/java/org/apache/iceberg/util/SerializableMap.java
@@ -26,6 +26,7 @@
 import org.apache.iceberg.relocated.com.google.common.collect.Maps;
 
 public class SerializableMap<K, V> implements Map<K, V>, Serializable {
+  private static final long serialVersionUID = 1L;
 
   private final Map<K, V> copiedMap;
   private transient volatile Map<K, V> immutableMap;