Skip to content

Commit

Permalink
Core: Enable strict metadata cleanup by default
Browse files Browse the repository at this point in the history
  • Loading branch information
amogh-jahagirdar committed Sep 20, 2023
1 parent 47ae4ac commit a32598a
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 7 deletions.
5 changes: 3 additions & 2 deletions core/src/main/java/org/apache/iceberg/TableOperations.java
Original file line number Diff line number Diff line change
Expand Up @@ -121,9 +121,10 @@ default long newSnapshotId() {
* Whether to clean up uncommitted metadata files only when a commit fails with a {@link
* CleanableFailure} exception.
*
* <p>This defaults to false: any unexpected exception will cause metadata files to be cleaned up.
* <p>This defaults to true: cleanup will only occur for exceptions marked as {@link
* CleanableFailure}
*/
default boolean requireStrictCleanup() {
return false;
return true;
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -240,9 +240,4 @@ public long newSnapshotId() {
}
};
}

@Override
public boolean requireStrictCleanup() {
return true;
}
}

0 comments on commit a32598a

Please sign in to comment.