Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create JUnit5-version of TableTestBase #9073

Closed
nastra opened this issue Nov 15, 2023 · 3 comments · Fixed by #9424
Closed

Create JUnit5-version of TableTestBase #9073

nastra opened this issue Nov 15, 2023 · 3 comments · Fixed by #9424
Labels
beginner Issues for apache iceberg beginners, enjoy to contribute ! good first issue Good for newcomers

Comments

@nastra
Copy link
Contributor

nastra commented Nov 15, 2023

Feature Request / Improvement

TableTestBase is using JUnit4 imports/mechanisms and is used as a base class for a lot of tests. In order to be able to migrate tests to JUnit5 that depend on this base class, we need a version of that class written in JUnit5.
During the migration process from JUnit4 to JUnit5 both versions of that class would co-exist.

Query engine

None

related issue: #7160

@nastra nastra added good first issue Good for newcomers beginner Issues for apache iceberg beginners, enjoy to contribute ! labels Nov 15, 2023
@lisirrx
Copy link
Contributor

lisirrx commented Nov 25, 2023

While #9122 is waiting for review, I want to start working on package iceberg-core, which makes me better understanding about the project and doing more contribution. Would you like to assign this issue to me?
I found that you raised this issue about the TableTestBase class , so maybe I can start from here.

I have read the discussion in #9120 which encoutered a similar situation. So in my understanding, an independent version of TableTestBase should be created with Junit5. I'm not sure about it's name, maybe TestBase is good enough.

After that, how the rest tests in iceberg-core be updated? inheriting the new TableTestBase or duplicating a new version?

@nastra
Copy link
Contributor Author

nastra commented Nov 27, 2023

@lisirrx yes we first need to have a JUnit5-version of TableTestBase (TestBase should be fine as a name) before we can convert any other tests that depend on this class.

To convert the existing tests to the new TestBase would mean to change the base class being used and switch to JUnit5 imports and AssertJ-style assertions.

@lisirrx
Copy link
Contributor

lisirrx commented Nov 28, 2023

@lisirrx yes we first need to have a JUnit5-version of TableTestBase (TestBase should be fine as a name) before we can convert any other tests that depend on this class.

To convert the existing tests to the new TestBase would mean to change the base class being used and switch to JUnit5 imports and AssertJ-style assertions.

ok, I'll work on this. Thanks for the detail information.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beginner Issues for apache iceberg beginners, enjoy to contribute ! good first issue Good for newcomers
Projects
Development

Successfully merging a pull request may close this issue.

2 participants