Create JUnit5 version of FlinkTestBase

[cgpoh]

• Add FlinkTestBaseJU5 and MiniClusterResourceJU5 class
• Fixes Create JUnit5-version of FlinkTestBase #9078

[pvary]

@cgpoh: We usually only create a PR for a single version of Flink (latest). After that PR is merged, then we create a backport PR to get the changes to the older versions. This helps the reviewer (smaller number of changes), and the contributor (if changes was requested then it is a smaller work) too.

Please avoid having the J5 in the class names - we would like to remove the old classes, and after that J5 classes will be hard to understand. Create a new package? Find a better name for the classes? Whatever works - but keep in mind the goal 😄

Please migrate at least one test class to the new base package, so we can try things out.

I have found that TemporaryFolder, GenericAppenderHelper should be migrated too to have a full Junit5 test infra.

[cgpoh]

@pvary , thanks! Will update the class name and revert the changes for Flink 1.15 and 1.16

[pvary]

This can be an update of the original TestCatalogTableLoader class, just instead of using the old FlinkTestBase, extend the new FlinkTestBaseUtils

[pvary]

So use the old class here, and extend the new base class. So it is easier to see, that all of the tests are the same, and also we do not need 2 test class for the same feature

[nastra]

+1 to that. We don't want to duplicate test classes themselves, but rather convert them from their Junit4 base class to their new Junit5 base class (once the new base class exists)

[cgpoh]

Thanks! Will update the old class instead

[pvary]

Could this be only TestBase, or ClusterTestBase? Or something similar?

[nastra]

+1 to using TestBase here

[cgpoh]

Thanks! Renaming to TestBase

[pvary]

@cgpoh: Please run ./gradlew spotlessApply before pushing the changes to fix splotless errors and minimally ./gradlew build -x test -x javadoc -x integrationTest to catch checkstyle errors.

[cgpoh]

@pvary will do. Thanks!

[pvary]

nit: Do you mind renaming this to MiniClusterExtension?

[cgpoh]

@pvary , I think I rename to MiniFlinkClusterExtension instead. If I rename to MiniClusterExtension, the following method will need to import MiniClusterExtension explicitly as below:

  public static org.apache.flink.test.junit5.MiniClusterExtension createWithClassloaderCheckDisabled() {
    return new org.apache.flink.test.junit5.MiniClusterExtension(
        new MiniClusterResourceConfiguration.Builder()
            .setNumberTaskManagers(DEFAULT_TM_NUM)
            .setNumberSlotsPerTaskManager(DEFAULT_PARALLELISM)
            .setConfiguration(DISABLE_CLASSLOADER_CHECK_CONFIG)
            .build());
  }

what do you think?

[pvary]

Agreed

[pvary]

Thanks for your work @cgpoh and @nastra for the review!

@cgpoh: Please create the backport PR to v1.15, v1.16. It could be one PR, and please make sure that the resulting code is the same. This helps in the long run when we are backporting new features.

[cgpoh]

Thanks! Will create the PR later