Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iceberg-flink: Switch tests to JUnit5 + AssertJ-style assertions #9087

Open
nastra opened this issue Nov 15, 2023 · 3 comments
Open

iceberg-flink: Switch tests to JUnit5 + AssertJ-style assertions #9087

nastra opened this issue Nov 15, 2023 · 3 comments
Assignees
Labels
beginner Issues for apache iceberg beginners, enjoy to contribute ! good first issue Good for newcomers

Comments

@nastra
Copy link
Contributor

nastra commented Nov 15, 2023

Feature Request / Improvement

The goal is to switch all imports to JUni5 imports and to use AssertJ-style assertions

depends on #9077 #9078 #9079

Query engine

Flink

@nastra nastra added good first issue Good for newcomers beginner Issues for apache iceberg beginners, enjoy to contribute ! labels Nov 15, 2023
@ilyasahsan123
Copy link

hi @nastra , could you please assign this task to me?

@ilyasahsan123
Copy link

Hi @nastra,

I've submitted a pull request PR #9565 to migrate unittests to JUnit5 in Flink v1.16.

I'm considering sending multiple pull requests for this migration since there are a lot of classes involved. This way, the review process can be more manageable, and you can provide feedback more efficiently.

Let me know if this approach works for you.

Thanks!

@tomtongue
Copy link
Contributor

@nastra If no one is assigned with this, could you assign this with me? I believe there are three remaining tasks like flink, spark other versions, data for the migration completion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beginner Issues for apache iceberg beginners, enjoy to contribute ! good first issue Good for newcomers
Projects
Development

No branches or pull requests

3 participants