Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create JUnit5-version of FlinkCatalogTestBase #9079

Closed
nastra opened this issue Nov 15, 2023 · 3 comments
Closed

Create JUnit5-version of FlinkCatalogTestBase #9079

nastra opened this issue Nov 15, 2023 · 3 comments
Labels
beginner Issues for apache iceberg beginners, enjoy to contribute ! good first issue Good for newcomers

Comments

@nastra
Copy link
Contributor

nastra commented Nov 15, 2023

Feature Request / Improvement

FlinkCatalogTestBase is using JUnit4 imports/mechanisms and is used as a base class for a lot of tests. In order to be able to migrate tests to JUnit5 that depend on this base class, we need a version of that class written in JUnit5.
During the migration process from JUnit4 to JUnit5 both versions of that class would co-exist.

Query engine

Flink
@nastra nastra added good first issue Good for newcomers beginner Issues for apache iceberg beginners, enjoy to contribute ! labels Nov 15, 2023
@nastra nastra mentioned this issue Nov 15, 2023
Open
@wanglijie95
Copy link

Hi @nastra , I'm interested in working on this issue, can I take it?

@wanglijie95 wanglijie95 mentioned this issue Nov 30, 2023
Merged
@vinitpatni vinitpatni mentioned this issue Dec 22, 2023
Merged
@vinitpatni
Copy link
Contributor

vinitpatni commented Jan 2, 2024 •
edited

@nastra I am not able to update PR on issue. Can you please link this PR: #9381

@nastra
Copy link
Contributor Author

nastra commented Apr 3, 2024

fixed by #9381 #9598

@nastra nastra closed this as completed Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
beginner Issues for apache iceberg beginners, enjoy to contribute ! good first issue Good for newcomers
Projects
JUnit4 to JUnit5 Migration
Status: Done
Milestone
No milestone
Development

No branches or pull requests
3 participants
@nastra @vinitpatni @wanglijie95