Core: Assign fresh IDs to view schema #10253
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nastra
force-pushed
the
view-assign-fresh-ids-for-schema
branch
2 times, most recently
from
0a21640
to
6d64913
Compare
nastra
force-pushed
the
view-assign-fresh-ids-for-schema
branch
from
6d64913
to
f378c67
Compare
nastra
commented
Apr 30, 2024
| private static final Schema OTHER_SCHEMA = | ||
| new Schema(7, required(1, "some_id", Types.IntegerType.get())); | ||
| new Schema( |
There was a problem hiding this comment.
changing this to show that the new column get's a re-assigned column ID
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses #9596 (comment) and assigns fresh IDs to a View's schema when creating/replacing a view