Spark: Coerce shorts and bytes into ints in Parquet Writer #10349
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10225
#9440 refactored the Spark Parquet writer to move to a visitor pattern. During this move, it removed some code required for coercion from bytes/shorts to int. This PR adds back the coercion code along with unit tests validating the change.
Note that even without coercion code, the tests succeed in Spark 3.5 but not in 3.3 and 3.4. It succeeds in 3.5 due to apache/spark#40734 which routes CTAS/RTAS through
AppendData
, in which case Spark adds its own projection to handle coercion here.So the change is not strictly necessary for Spark 3.5 but I add it anyway to: