Remove deprecated APIs up to 1.7.0 #10818
Open
+74
−181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nk1506
changed the title
findepi
reviewed
Jul 30, 2024
| public void testFileScanTaskParser(boolean caseSensitive) { | ||
| PartitionSpec spec = TestBase.SPEC; | ||
| FileScanTask fileScanTask = createFileScanTask(spec, caseSensitive); | ||
| String jsonStr = FileScanTaskParser.toJson(fileScanTask); |
There was a problem hiding this comment.
Should this test be removed, or adapted to use a non-deprecated method?
There was a problem hiding this comment.
There is already a test with new ScanTaskParser
nk1506
commented
Jul 31, 2024
| /** Test backward compatibility where task-type field is absent from the JSON string */ | ||
| @ParameterizedTest | ||
| @ValueSource(booleans = {true, false}) | ||
| public void testFileScanTaskParserWithoutTaskTypeField(boolean caseSensitive) { |
There was a problem hiding this comment.
Already a test with new ScanTaskParser
nk1506
commented
Jul 31, 2024
| @@ -163,10 +162,6 @@ private BoundMethod(UnboundMethod method, Object receiver) { | |||
| this.receiver = receiver; | |||
| } | |||
|
|
|||
| public <R> R invokeChecked(Object... args) throws Exception { | |||
There was a problem hiding this comment.
Thought to removed these unused methods after deprecating invokeChecked() . PLMK if it breaks any changes.
There was a problem hiding this comment.
this method wasn't marked as deprecated, so we can't remove it
nastra
reviewed
Jul 31, 2024
.palantir/revapi.yml
Outdated
| - code: "java.element.noLongerDeprecated" | ||
| old: "method void org.apache.iceberg.encryption.PlaintextEncryptionManager::<init>()" | ||
| new: "method void org.apache.iceberg.encryption.PlaintextEncryptionManager::<init>()" | ||
| justification: "Constructor became private as part of deprecations cleanup for 1.6.0 release" | ||
| justification: "Constructor became private as part of deprecations cleanup for\ |
nastra
reviewed
Jul 31, 2024
| @@ -82,14 +76,6 @@ public <R> R invoke(Object target, Object... args) { | |||
| return (R) newInstance(args); | |||
| } | |||
|
|
|||
| @Override | |||
| @SuppressWarnings("unchecked") | |||
There was a problem hiding this comment.
this method wasn't marked as deprecated?
nastra
reviewed
Jul 31, 2024
.palantir/revapi.yml
Outdated
| \ org.apache.iceberg.TableMetadata)" | ||
| new: "method org.apache.iceberg.BaseMetastoreOperations.CommitStatus org.apache.iceberg.BaseMetastoreTableOperations::checkCommitStatus(java.lang.String,\ | ||
| \ org.apache.iceberg.TableMetadata)" | ||
| justification: "Removing deprecated method" |
There was a problem hiding this comment.
can you update this message to Removing deprecated code instead of method?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.