Return metrics from the Parquet footer after writing. #137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rdsr
approved these changes
Mar 19, 2019
aokolnychyi
approved these changes
Mar 19, 2019
prodeezy
approved these changes
Mar 20, 2019
rdblue
force-pushed
the
add-parquet-metrics
branch
from
a96e390
to
a0622e4
Compare
|
Merged. Thanks for reviewing, @prodeezy, @rdsr, and @aokolnychyi! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@aokolnychyi and @prodeezy pointed out that
ParquetWriteAdapterdoesn't return metrics from the Parquet footer. This fixes the problem.