Pluggable file I/O submodule in TableOperations #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows custom implementations that share most of the behavior, but protected constructor prevents it from being instantiated improperly.
…perations-pluggable-io
mccheah
commented
Nov 27, 2018
core/src/main/java/com/netflix/iceberg/hadoop/HadoopFileIO.java
Outdated
Show resolved
Hide resolved
…perations-pluggable-io
|
@rdblue for review. |
|
@rdblue ping for review please! |
rdblue
reviewed
Dec 6, 2018
core/src/main/java/com/netflix/iceberg/hadoop/HadoopFileIO.java
Outdated
Show resolved
Hide resolved
rdblue
reviewed
Dec 6, 2018
rdblue
reviewed
Dec 6, 2018
rdblue
reviewed
Dec 6, 2018
rdblue
reviewed
Dec 6, 2018
core/src/main/java/com/netflix/iceberg/BaseMetastoreTableOperations.java
Show resolved
Hide resolved
rdblue
reviewed
Dec 6, 2018
core/src/main/java/com/netflix/iceberg/BaseMetastoreTableOperations.java
Outdated
Show resolved
Hide resolved
rdblue
reviewed
Dec 6, 2018
core/src/main/java/com/netflix/iceberg/BaseMetastoreTableOperations.java
Outdated
Show resolved
Hide resolved
rdblue
reviewed
Dec 6, 2018
rdblue
reviewed
Dec 6, 2018
rdblue
reviewed
Dec 6, 2018
core/src/main/java/com/netflix/iceberg/hadoop/HadoopTableOperations.java
Outdated
Show resolved
Hide resolved
|
Addressed comments and is ready for another pass of reviews. |
rdblue
reviewed
Dec 11, 2018
rdblue
reviewed
Dec 11, 2018
rdblue
reviewed
Dec 11, 2018
rdblue
reviewed
Dec 11, 2018
core/src/main/java/com/netflix/iceberg/hadoop/SerializableConfiguration.java
Outdated
Show resolved
Hide resolved
rdblue
reviewed
Dec 11, 2018
| public String metadataFileLocation(String fileName) { | ||
| return createdMetadataFilePaths.computeIfAbsent(fileName, name -> { | ||
| try { | ||
| return temp.newFile(name).getAbsolutePath(); |
There was a problem hiding this comment.
Shouldn't this still run delete() and deleteOnExit()?
There was a problem hiding this comment.
I believe TemporaryFolder knows to handle cleanup of data when it's torn down.
There was a problem hiding this comment.
You're right and that should take care of deleteOnExit. I thought that the delete was needed because it creates the file, but I guess not since tests are passing.
rdblue
reviewed
Dec 11, 2018
rdblue
reviewed
Dec 11, 2018
data/src/main/java/com/netflix/iceberg/data/TableScanIterable.java
Outdated
Show resolved
Hide resolved
|
Looks really close! Just minor issues right now. |
|
Addressed all comments so far. |
|
Merged. Thanks @mccheah! Nice work. |
rdblue
referenced
this pull request
in rdblue/iceberg
Dec 21, 2018
This adds FileIO that is returned by TableOperations and used to delete paths and to create InputFile and OutputFile instances. FileIO is Serializable so that it can be sent to tasks running in different JVMs and used for all file-related tasks for a table.
pvary
pushed a commit
to pvary/iceberg
that referenced
this pull request
Jan 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #12.
Separate patch to come for leveraging this submodule in the Iceberg clients, such as the Spark DataSource.