Nessie: Bump Nessie and add Namespace support #4385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nastra
force-pushed
the
add-namespace-support
branch
2 times, most recently
from
f8e92b1
to
970f2ca
Compare
nastra
commented
Mar 24, 2022
| Assertions.assertThatThrownBy(() -> catalog.dropNamespace(Namespace.of("test"))) | ||
| .isInstanceOf(UnsupportedOperationException.class) | ||
| .hasMessage("Cannot drop namespace 'test': dropNamespace is not supported by the NessieCatalog"); | ||
| public void testCreatingAndDroppingNamespace() { |
There was a problem hiding this comment.
additional Namespace testing will be added once we introduce a NessieCatalogTest
snazy
suggested changes
Mar 24, 2022
nessie/src/main/java/org/apache/iceberg/nessie/NessieCatalog.java
Outdated
Show resolved
Hide resolved
nessie/src/main/java/org/apache/iceberg/nessie/NessieCatalog.java
Outdated
Show resolved
Hide resolved
nastra
force-pushed
the
add-namespace-support
branch
from
970f2ca
to
fd52086
Compare
snazy
approved these changes
Mar 24, 2022
rymurr
reviewed
Apr 1, 2022
| @Override | ||
| public void createNamespace(Namespace namespace, Map<String, String> metadata) { | ||
| try { |
There was a problem hiding this comment.
I notice metadata is ignored but the javadoc is removed, can you add it back.
There was a problem hiding this comment.
I have a follow-up PR for that part of the code and will add that note there if that's ok?
rymurr
approved these changes
Apr 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.