Flink - Remove support for Flink 1.12 #4551
Conversation
| @@ -1,7 +1,7 @@ | |||
| org.slf4j:* = 1.7.25 | |||
| org.apache.avro:avro = 1.10.1 | |||
| org.apache.calcite:* = 1.10.0 | |||
| org.apache.flink:* = 1.12.5 | |||
| org.apache.flink:* = 1.14.3 | |||
There was a problem hiding this comment.
I don't think this is being used at all given we've moved to versioned Flink dependencies, but I updated it to the latest released Flink version.
Realistically we should potentially get rid of it, as well as others that aren't used now.
The calcite dependency is also somewhat suspect.
There was a problem hiding this comment.
yeah. it does seem that we can remove this property
There was a problem hiding this comment.
There are a few that I think can be removed (eg the Spark dependencies).
One that I’m less sure about is Calcite
I can remove the Flink property in this PR or attempt to clean up several in a secondary PR (or both).
There was a problem hiding this comment.
I'm okay to remove this in the future PR.
kbendick
changed the title
There was a problem hiding this comment.
Looks good to me overall ! Thanks @kbendick for the contribution, and thanks @stevenzwu & @hililiwei for the reviewing !
Remove support for Flink 1.12, which has been deprecated.
Flink 1.12 has been deprecated and is no longer actively maintained upstream, as the Flink community retains support for 2 major versions at a time.