Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parquet: Release the compressor when calling close in ParquetWriter #5126

Merged
merged 1 commit into from
Jun 27, 2022

Conversation

hmit
Copy link
Contributor

@hmit hmit commented Jun 23, 2022

No description provided.

@hmit
Copy link
Contributor Author

hmit commented Jun 23, 2022

I discovered this after switching to ParquetWriter from iceberg project.
Without this, we see this log message when using Brotli compression to write data files to iceberg.

Copy link
Member

@jzhuge jzhuge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The commit message should have prefix "Parquet: " instead of "Core: ".

@hmit hmit changed the title Core: Release the compressor when calling close in ParquetWriter Parquet: Release the compressor when calling close in ParquetWriter Jun 24, 2022
Copy link
Contributor

@kbendick kbendick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1. Good catch @hmit!

I tried to find a place where this could be tested, but there didn't seem to be anywhere that was already testing whether or not things were closed so I think it's fine without it.

@hmit
Copy link
Contributor Author

hmit commented Jun 24, 2022

+1. Good catch @hmit!

I tried to find a place where this could be tested, but there didn't seem to be anywhere that was already testing whether or not things were closed so I think it's fine without it.

Yeah, I didn't find a good unit-test to add this to. However, we did test it by deploying (with brotli compression) and it seems to do the trick.

@jzhuge
Copy link
Member

jzhuge commented Jun 27, 2022

@kbendick Could you please merge this PR?

@szehon-ho szehon-ho merged commit 443fee4 into apache:master Jun 27, 2022
@szehon-ho
Copy link
Collaborator

Thanks @hmit , and @kbendick @jzhuge for review

@hmit
Copy link
Contributor Author

hmit commented Jun 27, 2022

Thanks all for the quick review and merge!

@jzhuge
Copy link
Member

jzhuge commented Jun 27, 2022

Thanks @hmit for discovering the issue and providing a fix. Thanks @kbendick for review. Thanks @szehon-ho for review and merge!

@kbendick
Copy link
Contributor

@kbendick Could you please merge this PR?

Sorry I couldn't merge this. I don't have that permission yet (hopefully soon). But glad this is in and appreciate the contributions 👍

namrathamyske pushed a commit to namrathamyske/iceberg that referenced this pull request Jul 10, 2022
namrathamyske pushed a commit to namrathamyske/iceberg that referenced this pull request Jul 10, 2022
zzhhhzz added a commit to zzhhhzz/iceberg that referenced this pull request Apr 17, 2023
puchengy pushed a commit to pinterest/iceberg that referenced this pull request Apr 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants