Core: Rename HMS_TABLE_OWNER to follow naming convention #6154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nastra
approved these changes
Nov 9, 2022
szehon-ho
approved these changes
Nov 9, 2022
|
Makes sense based on discussion: #6045 (comment) . Thanks @gaborkaszab and @nastra for review |
Fokko
pushed a commit
to Fokko/iceberg
that referenced
this pull request
Nov 11, 2022
asfgit
pushed a commit
to apache/impala
that referenced
this pull request
Nov 16, 2023
IMPALA-11429 made the creation of an Iceberg table happen in 2 steps. The first step creates the table, however, with wrong owner and the second step is an ALTER TABLE to set the correct table owner. Since Iceberg 1.1.0 there is now a way to provide a table owner via a table property so we can make the create table operation to take one step again. apache/iceberg#5763 apache/iceberg#6154 This patch implements this behavior, when creating an Iceberg table through HiveCatalog, specifying HMS_TABLE_OWNER as hive.metastore.table.owner in properties can do it in one step. Testing: - Use the existing test test_iceberg.py test_table_owner. Change-Id: I56ef7929449105af571d1fb9cb585d9b0733a39d Reviewed-on: http://gerrit.cloudera.org:8080/20646 Reviewed-by: Impala Public Jenkins <impala-public-jenkins@cloudera.com> Tested-by: Impala Public Jenkins <impala-public-jenkins@cloudera.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I introduced this property in #5763, however, I learned since that its value doesn't follow the naming conventions for a table property. Fortunately the change hasn't been released yet so we can safely change this property before we release 1.1.0. and won't hurt backward compatibility.