Spark: Surface better error message during streaming planning when checkpoint snapshot not found #6480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spark/v3.3/spark/src/main/java/org/apache/iceberg/spark/source/SparkMicroBatchStream.java
Outdated
Show resolved
Hide resolved
amogh-jahagirdar
force-pushed
the
spark-streaming-snapshot-fix
branch
from
69f12bc
to
7394d5e
Compare
|
Seems like surfacing a better error message is indeed the right fix for this situation based on a new issue which came up: #7340 I've updated with a test cc @aokolnychyi @RussellSpitzer @szehon-ho @singhpk234 @jackye1995 |
|
|
||
| if (snapshot == null) { | ||
| throw new IllegalStateException( | ||
| String.format("Failed to find expected snapshot %d", currentOffset.snapshotId())); |
There was a problem hiding this comment.
I think we can probably improve this message. "Cannot load current offset at snapshot x, the snapshot was expired or removed"?
I'm trying to figure out how we can give the user a bit more information about what to do in this situation. Our currentOffset should always have a valid snapshot ID so I think it's probably ok to just say that that the snapshot was actually expired if we can't find it?
There was a problem hiding this comment.
Agreed, it'll be helpful to provide the context that expiration or some external mechanism somehow removed the snapshot, will update
RussellSpitzer
approved these changes
Apr 19, 2023
jackye1995
approved these changes
Apr 19, 2023
amogh-jahagirdar
force-pushed
the
spark-streaming-snapshot-fix
branch
from
7394d5e
to
2b499cd
Compare
amogh-jahagirdar
changed the title
…eckpoint snapshot not found
amogh-jahagirdar
force-pushed
the
spark-streaming-snapshot-fix
branch
from
2b499cd
to
110b9d1
Compare
amogh-jahagirdar
changed the title
|
Looks like the message is updated, thanks Amogh! |
aokolnychyi
pushed a commit
to aokolnychyi/iceberg
that referenced
this pull request
Apr 20, 2023
…n checkpoint snapshot not found (apache#6480) (cherry picked from commit 456c926)
amogh-jahagirdar
added a commit
to amogh-jahagirdar/iceberg
that referenced
this pull request
Apr 25, 2023
amogh-jahagirdar
added a commit
to amogh-jahagirdar/iceberg
that referenced
this pull request
Apr 25, 2023
amogh-jahagirdar
added a commit
to amogh-jahagirdar/iceberg
that referenced
this pull request
Apr 25, 2023
Fokko
pushed a commit
that referenced
this pull request
Apr 25, 2023
coufon
pushed a commit
to coufon/iceberg
that referenced
this pull request
Apr 25, 2023
manisin
pushed a commit
to Snowflake-Labs/iceberg
that referenced
this pull request
May 9, 2023
…eckpoint snapshot not found (apache#6480)
manisin
pushed a commit
to Snowflake-Labs/iceberg
that referenced
this pull request
May 9, 2023
…n checkpoint snapshot not found (apache#7381) This change backports PR apache#6480 to 3.3. Co-authored-by: Amogh Jahagirdar <jahamogh@amazon.com>
manisin
pushed a commit
to Snowflake-Labs/iceberg
that referenced
this pull request
May 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6388.
Based on the stack trace the following sequence of events seems plausible.
1.) The snapshot ID for current offset no longer exists (my hunch is due to expiration). So table.snapshot(currentOffset.snapshotId()) returns null.
2.) Then planning throws an unclear NPE here when trying to get the operation associated with the snapshot.
This is possible when resuming reading from a checkpoint where the snapshot associated with the checkpoint was expired.