Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Separate page for Branching and Tagging #6723

Merged
merged 1 commit into from
Apr 25, 2023

Conversation

amogh-jahagirdar
Copy link
Contributor

@amogh-jahagirdar amogh-jahagirdar commented Feb 1, 2023

This change adds a separate page in Iceberg docs under the "Tables" section focused on branching and tagging.

cc: @jackye1995 @rdblue @namrathamyske @nastra @singhpk234 @rajarshisarkar @aokolnychyi @RussellSpitzer

@github-actions github-actions bot added the docs label Feb 1, 2023
Copy link
Contributor

@nastra nastra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall LGTM, just a few small things

docs/branching-and-tagging.md Outdated Show resolved Hide resolved
docs/branching-and-tagging.md Outdated Show resolved Hide resolved
docs/branching-and-tagging.md Outdated Show resolved Hide resolved
docs/branching-and-tagging.md Outdated Show resolved Hide resolved
docs/branching-and-tagging.md Outdated Show resolved Hide resolved
docs/branching-and-tagging.md Outdated Show resolved Hide resolved
docs/branching-and-tagging.md Outdated Show resolved Hide resolved
docs/branching-and-tagging.md Outdated Show resolved Hide resolved
docs/spark-writes.md Outdated Show resolved Hide resolved
@amogh-jahagirdar amogh-jahagirdar force-pushed the branching-tagging-docs branch 4 times, most recently from 8f5ae46 to bc6fa21 Compare March 24, 2023 06:39
@amogh-jahagirdar amogh-jahagirdar force-pushed the branching-tagging-docs branch 2 times, most recently from 8910681 to aaa3aee Compare March 27, 2023 02:48
@amogh-jahagirdar amogh-jahagirdar force-pushed the branching-tagging-docs branch 2 times, most recently from 4e4207b to dcb8cb3 Compare March 27, 2023 03:16
@amogh-jahagirdar amogh-jahagirdar force-pushed the branching-tagging-docs branch 4 times, most recently from 32fdbd6 to 6ecc6d1 Compare April 1, 2023 23:48
docs/flink-queries.md Outdated Show resolved Hide resolved
Copy link
Contributor

@jackye1995 jackye1995 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

@jackye1995
Copy link
Contributor

@nastra @hililiwei @namrathamyske @holdenk do you have any further comments?

docs/flink-queries.md Outdated Show resolved Hide resolved
Copy link
Contributor

@hililiwei hililiwei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jackye1995
Copy link
Contributor

Thanks for the work Amogh, and thanks everyone for the review. Since this has been open for quite some time, I will go ahead to merge it, and we can address any additional feedback afterwards.

@jackye1995 jackye1995 merged commit 8459fa0 into apache:master Apr 25, 2023
2 checks passed
coufon pushed a commit to coufon/iceberg that referenced this pull request Apr 25, 2023
manisin pushed a commit to Snowflake-Labs/iceberg that referenced this pull request May 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants