Improve Error Handling to map Snowflake Exceptions into Iceberg Exceptions #6952
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improve Error Handling to map Snowflake Exceptions into Iceberg Exceptions
nastra
requested changes
Mar 2, 2023
snowflake/src/main/java/org/apache/iceberg/snowflake/JdbcSnowflakeClient.java
Outdated
Show resolved
Hide resolved
snowflake/src/test/java/org/apache/iceberg/snowflake/JdbcSnowflakeClientTest.java
Show resolved
Hide resolved
snowflake/src/test/java/org/apache/iceberg/snowflake/JdbcSnowflakeClientTest.java
Show resolved
Hide resolved
snowflake/src/main/java/org/apache/iceberg/snowflake/JdbcSnowflakeClient.java
Outdated
Show resolved
Hide resolved
nastra
approved these changes
Mar 6, 2023
There was a problem hiding this comment.
LGTM, @danielcweeks could you also take a look at this please?
snowflake/src/main/java/org/apache/iceberg/snowflake/JdbcSnowflakeClient.java
Outdated
Show resolved
Hide resolved
danielcweeks
reviewed
May 5, 2023
snowflake/src/main/java/org/apache/iceberg/snowflake/JdbcSnowflakeClient.java
Outdated
Show resolved
Hide resolved
danielcweeks
reviewed
May 5, 2023
snowflake/src/main/java/org/apache/iceberg/snowflake/JdbcSnowflakeClient.java
Outdated
Show resolved
Hide resolved
danielcweeks
approved these changes
May 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve Error Handling to map Snowflake Exceptions into Iceberg Exceptions
The Snowflake JDBC Client was throwing generic exceptions in some scenarios (Eg: UncheckedSQLException), this change maps them to the appropriate Iceberg Exceptions to help the retry/error-handling mechanism in Iceberg.
Added test cases as well.