Core: Refactor actions results #7089
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc: @nastra, @aokolnychyi, @rdblue, @jackye1995 |
nastra
approved these changes
Mar 15, 2023
| @@ -21,6 +21,8 @@ | |||
| import org.apache.iceberg.StructLike; | |||
| import org.apache.iceberg.relocated.com.google.common.base.MoreObjects; | |||
|
|
|||
| /** @deprecated will be removed in 1.3.0. */ | |||
There was a problem hiding this comment.
I think the deprecation message should mention what should be used alternatively. Also the version might need to be updated (depending on when this gets merged)
There was a problem hiding this comment.
added the alternative and changed the version to 1.4.0 as 1.2.0 voting is already in progress.
JonasJ-ap
approved these changes
Mar 16, 2023
jackye1995
approved these changes
Mar 16, 2023
|
Since. 1.2.0 release vote is passed. This can be merged now I guess. Thanks. |
|
Merging, thanks for the change! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Each action has a separate boilerplate code with the public constructor. Which is hard to maintain. Also, the addition of new fields requires deprecating older constructors and adding a new one.
Recently two of the PRs (#6801, and #6091) also had to go through new constructors.
Changes:
This is a follow-up on #6091 (comment)
Note: only spark-3.3 is using the new builders. Other versions are still using the newly deprecated builders.
Will be replaced in a single follow-up PR after the review.