Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Aliyun: Remove AssertHelpers #7116

Merged
merged 3 commits into from
Mar 20, 2023
Merged

Aliyun: Remove AssertHelpers #7116

merged 3 commits into from
Mar 20, 2023

Conversation

liuxiaocs7
Copy link
Member

Remove AssertHelpers in iceberg-aliyun module

@liuxiaocs7
Copy link
Member Author

liuxiaocs7 commented Mar 15, 2023 •
edited

@nastra This is the beginning of issue-#7094, which solves the problem of the aliyun module, I am not quite sure that the requirements are met, please review it for me when you have time, thx.

@liuxiaocs7
Copy link
Member Author

@nastra Please take a look again when you are free, thx.

nastra
nastra approved these changes Mar 17, 2023
View reviewed changes
Copy link
Contributor

@nastra nastra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, @jackye1995 could you also take a look please?

aliyun/src/test/java/org/apache/iceberg/aliyun/oss/TestOSSInputStream.java Outdated Show resolved Hide resolved
jackye1995
jackye1995 approved these changes Mar 18, 2023
View reviewed changes
Copy link
Contributor

@jackye1995 jackye1995 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, waiting for CI

@liuxiaocs7
Copy link
Member Author

Hi, @jackye1995 The CI has passed, PTAL.

@jackye1995
Copy link
Contributor

Given this is just method deprecation, I will go ahead to merge it instead of waiting for more approvals, thanks @liuxiaocs7 and thanks @nastra for the review!

@jackye1995 jackye1995 merged commit e82ecf6 into apache:master Mar 20, 2023
@amshali
Copy link

amshali commented Oct 4, 2023

I am working on iceberg-flink module.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nastra nastra nastra approved these changes

@jackye1995 jackye1995 jackye1995 approved these changes

Assignees
No one assigned
Labels
ALIYUN
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@liuxiaocs7 @jackye1995 @amshali @nastra