Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MR: Remove deprecate AssertHelpers #7159

Merged
merged 4 commits into from
Mar 21, 2023
Merged

MR: Remove deprecate AssertHelpers #7159

merged 4 commits into from
Mar 21, 2023

Conversation

liuxiaocs7
Copy link
Member

Remove AssertHelpers in iceberg-mr module

@github-actions github-actions bot added the MR label Mar 21, 2023
@liuxiaocs7
Copy link
Member Author

Hi, @nastra, @jackye1995, please help me take a look, thanks!

nastra
nastra approved these changes Mar 21, 2023
View reviewed changes
Copy link
Contributor

@nastra nastra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with some nits, thanks @liuxiaocs7

mr/src/test/java/org/apache/iceberg/mr/hive/TestHiveIcebergStorageHandlerNoScan.java Outdated Show resolved Hide resolved
mr/src/test/java/org/apache/iceberg/mr/hive/TestHiveIcebergStorageHandlerNoScan.java Show resolved Hide resolved
@liuxiaocs7 liuxiaocs7 requested a review from nastra March 21, 2023 12:52
jackye1995
jackye1995 approved these changes Mar 21, 2023
View reviewed changes
Copy link
Contributor

@jackye1995 jackye1995 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

@jackye1995
Copy link
Contributor

Thanks for the work @liuxiaocs7 and thanks for the review @nastra !

@jackye1995 jackye1995 merged commit ee08ce5 into apache:master Mar 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nastra nastra nastra approved these changes

@jackye1995 jackye1995 jackye1995 approved these changes

Assignees
No one assigned
Labels
MR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@liuxiaocs7 @jackye1995 @nastra