Flink: Backport #6614 to Flink 1.15 #7165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xuzhiwen1255
changed the title
xuzhiwen1255
force-pushed
the
flink1.15-backport-6614
branch
from
ed402c2
to
5d45e1a
Compare
|
@xuzhiwen1255 I assume you checked the diff that there is nothing related to this change, right? |
|
@stevenzwu Yes, but I found a problem, abc forgot to implement the Cloneable interface. |
|
Do I need a separate pr to fix this interface problem? |
|
@stevenzwu I mentioned a pr #7168 that fixes missing code in #6614 . |
|
@xuzhiwen1255 the hotfix has been merged |
|
Thanks @stevenzwu , I've checked the diff and no extraneous code is involved. |
stevenzwu
approved these changes
Mar 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport....