Python: Relax the pin for fsspec
implementations
#7242
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm proposing a minimal change to relax
fsspec
,s3fs
,adlfs
again (after #6745 relaxed a bit).Specifically, I want to be able to leverage fsspec/s3fs#704 (or fsspec/filesystem_spec#1194) to provide the endpoint URL. Previously, I was doing something custom:
However, since asking about this on Slack, I've found that most environment variables will be read by
pyiceberg
by way ofs3fs
(e.g.AWS_ACCESS_KEY_ID
,AWS_SECRET_ACCESS_KEY
), and thatfsspec
/s3fs
have recently provided (better) ways to even configure endpoint URL. So I'd like to leverage them. :)As somebody developing a library that has a dependency on
pyiceberg
, there's a broader issue of not pinning versions so tightly, but I will create a separate issue on that.