Core: Fix SnapshotProducer#targetBranch's exception message #7315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
This is a great catch @zhongyujiang the fix looks good to me. can we add a unit test for this? This bug implies this precondition check is not tested so it would be good to have coverage though.
zhongyujiang
commented
Apr 11, 2023
| .as("Invalid branch") | ||
| .isInstanceOf(IllegalArgumentException.class) | ||
| .hasMessageContaining( | ||
| "some-tag is a tag, not a branch. Tags cannot be targets for producing snapshots"); |
There was a problem hiding this comment.
@amogh-jahagirdar These two unit tests already test the precondition check, but the exception msg is not validated, so I updated them.
amogh-jahagirdar
approved these changes
Apr 11, 2023
nastra
approved these changes
Apr 12, 2023
| () -> table.newFastAppend().appendFile(FILE_A).toBranch("some-tag").commit()) | ||
| .as("Invalid branch") | ||
| .isInstanceOf(IllegalArgumentException.class) | ||
| .hasMessageContaining( |
There was a problem hiding this comment.
nit: hasMessage would be better here, since we can match the full error msg
| Assertions.assertThatThrownBy(() -> table.newFastAppend().appendFile(FILE_A).toBranch(null)) | ||
| .as("Invalid branch") | ||
| .isInstanceOf(IllegalArgumentException.class) | ||
| .hasMessageContaining("Invalid branch name: null"); |
There was a problem hiding this comment.
nit: hasMessage would be better here, since we can match the full error msg
nastra
approved these changes
Apr 12, 2023
szehon-ho
approved these changes
Apr 12, 2023
|
Merged, thanks @zhongyujiang , and @amogh-jahagirdar , @nastra for reviews |
manisin
pushed a commit
to Snowflake-Labs/iceberg
that referenced
this pull request
May 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.