Flink: move the classes from flink.sink.shuffle.statistics pkg to one level up as flink.sink.shuffle pkg #7322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… level up as flink.sink.shuffle pkg
yegangy0718
approved these changes
Apr 11, 2023
|
will merge. there is no code change. just simple package reorg to reduce the depth of packages. also verified the diff |
ericlgoodman
pushed a commit
to ericlgoodman/iceberg
that referenced
this pull request
Apr 12, 2023
… level up as flink.sink.shuffle pkg (apache#7322)
manisin
pushed a commit
to Snowflake-Labs/iceberg
that referenced
this pull request
May 9, 2023
… level up as flink.sink.shuffle pkg (apache#7322)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We may have 20 classes in the
shufflepackage. seems not necessary to have astatisticssub package undershuffle. and the classes are more tightly related that we have to make the statistics class public if living inside a sub package.