Spark 3.4: Relax constraints in SparkPartitioningAwareScan #7423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
singhpk234
approved these changes
Apr 25, 2023
There was a problem hiding this comment.
LGTM, Thanks @aokolnychyi !
Great to see spark itself adding an empty partition for filtered out grouping key rather than we explicitly adding an empty TaskGroup for it !!!!
RussellSpitzer
approved these changes
Apr 25, 2023
|
Thanks, @singhpk234 @RussellSpitzer! |
coufon
pushed a commit
to coufon/iceberg
that referenced
this pull request
Apr 28, 2023
manisin
pushed a commit
to Snowflake-Labs/iceberg
that referenced
this pull request
May 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR simplifies
SparkPartitioningAwareScanas SPARK-41398 is part of 3.4. We no longer have to ensure the same set of keys is reported back to Spark after runtime filtering. No new tests are needed as existing tests would fail without this logic.