Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spark: Fixed Typo in Spark Read Option Vectorization Javadoc #7439

Merged
merged 3 commits into from
Apr 27, 2023
Merged

Spark: Fixed Typo in Spark Read Option Vectorization Javadoc #7439

merged 3 commits into from
Apr 27, 2023

Conversation

vishnukumarsinha
Copy link
Contributor

Closes #7438

@github-actions github-actions bot added the spark label Apr 26, 2023
@vishnukumarsinha
Copy link
Contributor Author

HI @RussellSpitzer, Please review this PR.

RussellSpitzer
RussellSpitzer reviewed Apr 27, 2023
View reviewed changes
spark/v3.4/spark/src/main/java/org/apache/iceberg/spark/SparkReadOptions.java Outdated
@@ -56,7 +56,7 @@ private SparkReadOptions() {}
// Overrides the table's read.split.open-file-cost
public static final String FILE_OPEN_COST = "file-open-cost";

// Overrides the table's read.split.open-file-cost
// Overrides the table's read.parquet.vectorization.vectorization-enabled
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As I mentioned on the issue, this also overrides the orc version. May be worth to just note that this "Overrides table's vectorization enabled properties"

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/apache/iceberg/blob/master/spark/v3.4/spark/src/main/java/org/apache/iceberg/spark/SparkReadConf.java#L143 - Parquet
https://github.com/apache/iceberg/blob/master/spark/v3.4/spark/src/main/java/org/apache/iceberg/spark/SparkReadConf.java#L162 - ORC

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated it, please give a second look. Thanks!

RussellSpitzer
RussellSpitzer approved these changes Apr 27, 2023
View reviewed changes
Copy link
Member

@RussellSpitzer RussellSpitzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, will merge after CI

@RussellSpitzer RussellSpitzer merged commit 1969775 into apache:master Apr 27, 2023
31 checks passed
@RussellSpitzer
Copy link
Member

Merged, Thanks @vishnukumarsinha

coufon pushed a commit to coufon/iceberg that referenced this pull request Apr 28, 2023
@vishnukumarsinha @coufon
Spark: Fixed Typo in Spark Read Option Vectorization Javadoc (apache#…
405a6eb 
…7439)
manisin pushed a commit to Snowflake-Labs/iceberg that referenced this pull request May 9, 2023
@vishnukumarsinha @manisin
Spark: Fixed Typo in Spark Read Option Vectorization Javadoc (apache#…
a67f8dd 
…7439)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RussellSpitzer RussellSpitzer RussellSpitzer approved these changes

Assignees
No one assigned
Labels
spark
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Typo in Spark Read Option Vectorization Javadoc
2 participants
@vishnukumarsinha @RussellSpitzer