Hive: Support connecting to multiple Hive-Catalog #7441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pvary
approved these changes
Apr 27, 2023
pvary
reviewed
Apr 27, 2023
| @@ -64,10 +64,15 @@ public class HiveCatalog extends BaseMetastoreCatalog implements SupportsNamespa | |||
| public static final String LIST_ALL_TABLES = "list-all-tables"; | |||
| public static final String LIST_ALL_TABLES_DEFAULT = "false"; | |||
|
|
|||
| public static final String HMS_CATALOG = "hive-catalog"; | |||
There was a problem hiding this comment.
Do we have to document this?
There was a problem hiding this comment.
Good point, will do in follow-up pr
There was a problem hiding this comment.
Actually decided not to add this extra config for now, as user can use spark.sql.catalog.$myCatalog.hadoop.metastore.catalog.default. Can revisit this later, but for now there's no new flag introduced.
hililiwei
approved these changes
Apr 28, 2023
|
Thanks. Yes, it depends on engine, I believe Spark has this support. |
|
Test failed looks unrelated, kicking off again |
|
Last test cleanup is not related to failure (is just good to clear for next test). Thanks @pvary @hililiwei for review |
manisin
pushed a commit
to Snowflake-Labs/iceberg
that referenced
this pull request
May 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: As the term Hive-Catalog is overloaded across, I'll use "Iceberg-HiveCatalog" to refer to Iceberg's HiveCatalog class and "HMS Catalog" to refer to Hive specific concept.
https://issues.apache.org/jira/browse/HIVE-18685 added support for HMS catalogs, ie different namespaces for dbs/tables in the metastore.
However, the Iceberg-HiveCatalog uses a global cache of HMS connections based on Hive-Metastore-URI. This prevents different Iceberg-HiveCatalogs existing in same JVM from talking to different HMS Catalogs on same HMS. See issue: #5378. This is important for example in Spark, where user may try to configure different SparkCatalog pointing to separate catalog on same HMS.
This change takes advantage of #6698 to fix this. It does two things:
From Spark point of view, user can configure 'spark.sql.catalog.$cat1.hive-catalog=foo', 'spark.sql.catalog.$cat2.hive-catalog=bar'.
Note; @RussellSpitzer pointed to me that setting spark.sql.catalog.$myCatalog.hadoop.metastore.catalog.default=foo seems to work to configure each SparkCatalog. But it is a bit clunky and undocumented, and hence the proposal to add 'hive_catalog' shorthand.
In either case, the second change is needed to allow different cached connections on same HMS to go to different HMS-catalogs.