Delta Migration: Add version and timestamp tags for each Delta Lake transaction when add to Iceberg transaction #7450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rushan Jiang <rushanj@andrew.cmu.edu>
Signed-off-by: Rushan Jiang <rushanj@andrew.cmu.edu>
jackye1995
reviewed
Apr 27, 2023
delta-lake/src/main/java/org/apache/iceberg/delta/BaseSnapshotDeltaLakeTableAction.java
Outdated
Show resolved
Hide resolved
jackye1995
reviewed
Apr 27, 2023
delta-lake/src/main/java/org/apache/iceberg/delta/BaseSnapshotDeltaLakeTableAction.java
Show resolved
Hide resolved
jackye1995
reviewed
Apr 27, 2023
| deltaVersionTimestamp | ||
| .toInstant() | ||
| .atZone(ZoneId.of(DELTA_TIME_STAMP_ZONE)) | ||
| .format(DateTimeFormatter.ofPattern(DELTA_TIME_STAMP_FORMAT)); |
There was a problem hiding this comment.
I am wondering how much it is worth doing this conversion, instead of just using the millisecond timestamp value. Any thoughts?
There was a problem hiding this comment.
Thought about this a bit more, I think I would +1 for just using raw millisecond timestamp. Dealing with timezone is complex and should be avoided if there is no significant benefit. Also it leaves a space character in the tag, that might cause issue.
Signed-off-by: Rushan Jiang <rushanj@andrew.cmu.edu>
Signed-off-by: Rushan Jiang <rushanj@andrew.cmu.edu>
|
Thanks for adding the feature Jonas! |
manisin
pushed a commit
to Snowflake-Labs/iceberg
that referenced
this pull request
May 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6769
For each Iceberg transaction migrated, add
delta-version-xxxanddelta-ts-xxxxxtag to the snapshot.delta-version-xxxrepresents the logical delta lake version.delta-ts-xxxxxrepresents the commit time of the corresponding delta lake transaction