Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spark 3.4: Switch to built-in DELETE implementation #7453

Merged
merged 1 commit into from
May 1, 2023

Conversation

aokolnychyi
Copy link
Contributor

@aokolnychyi aokolnychyi commented Apr 27, 2023

This PR migrates our DELETE commands to use the built-in implementation, which should be fully compatible now.

@github-actions github-actions bot added the spark label Apr 27, 2023
Copy link
Contributor

@singhpk234 singhpk234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks @aokolnychyi !

@dramaticlly
Copy link
Contributor

thank you Anton, for my own curiosity, is this coming from feature released in spark 3.4?

@aokolnychyi
Copy link
Contributor Author

@dramaticlly, yep, it was delivered as part of SPARK-35801. UPDATE and MERGE are still pending.

Copy link
Contributor

@amogh-jahagirdar amogh-jahagirdar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, thanks @aokolnychyi

@aokolnychyi aokolnychyi merged commit 9de9a2a into apache:master May 1, 2023
31 checks passed
@aokolnychyi
Copy link
Contributor Author

Thanks for reviewing, @singhpk234 @amogh-jahagirdar!

manisin pushed a commit to Snowflake-Labs/iceberg that referenced this pull request May 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants