Core: Add FileIO tracker/closer to REST catalog #7487
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nastra
force-pushed
the
fileio-cache-in-rest-catalog
branch
from
c462e42
to
06a4b5b
Compare
nastra
commented
May 1, 2023
nastra
commented
May 1, 2023
core/src/main/java/org/apache/iceberg/rest/RESTSessionCatalog.java
Outdated
Show resolved
Hide resolved
|
CI seems to fail due to |
danielcweeks
reviewed
May 2, 2023
nastra
force-pushed
the
fileio-cache-in-rest-catalog
branch
from
06a4b5b
to
8c101e9
Compare
nastra
changed the title
nastra
changed the title
rdblue
reviewed
May 3, 2023
core/src/main/java/org/apache/iceberg/rest/RESTSessionCatalog.java
Outdated
Show resolved
Hide resolved
rdblue
reviewed
May 3, 2023
core/src/main/java/org/apache/iceberg/rest/RESTSessionCatalog.java
Outdated
Show resolved
Hide resolved
rdblue
reviewed
May 3, 2023
core/src/main/java/org/apache/iceberg/rest/RESTSessionCatalog.java
Outdated
Show resolved
Hide resolved
rdblue
reviewed
May 3, 2023
rdblue
reviewed
May 3, 2023
core/src/main/java/org/apache/iceberg/rest/RESTSessionCatalog.java
Outdated
Show resolved
Hide resolved
rdblue
reviewed
May 3, 2023
| .removalListener( | ||
| (RemovalListener<TableOperations, FileIO>) | ||
| (ops, fileIO, cause) -> { | ||
| if (null != fileIO) { |
There was a problem hiding this comment.
the API contract of the RemovalListener marks keys/values as being @Nullable: void onRemoval(@Nullable K key, @Nullable V value, @NonNull RemovalCause cause);
Since we're not using weakValues() here the value shouldn't be null as indicated by the Javadoc, so this is rather to be defensive and avoid warnings in IntelliJ (we have the same warning a few lines above in the session cache btw)
nastra
force-pushed
the
fileio-cache-in-rest-catalog
branch
from
8c101e9
to
e014c43
Compare
rdblue
reviewed
May 3, 2023
core/src/main/java/org/apache/iceberg/rest/RESTSessionCatalog.java
Outdated
Show resolved
Hide resolved
nastra
force-pushed
the
fileio-cache-in-rest-catalog
branch
from
e014c43
to
60cf024
Compare
nastra
force-pushed
the
fileio-cache-in-rest-catalog
branch
from
60cf024
to
803e990
Compare
rdblue
approved these changes
May 16, 2023
|
Thanks for fixing this, @nastra! Good to have it in. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.