-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Spark 3.3: Add read and write support for UUIDs #7496
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM as well, Thanks @nastra !
@@ -85,6 +85,9 @@ private static class UUIDWriter implements OrcValueWriter<UTF8String> { | |||
|
|||
@Override | |||
public void nonNullWrite(int rowId, UTF8String data, ColumnVector output) { | |||
// ((BytesColumnVector) output).setRef(..) just stores a reference to the passed byte[], so | |||
// can't use a ThreadLocal ByteBuffer here like in other places because subsequent writes | |||
// would then overwrite previous values |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
This backports #7399 to Spark 3.3