Make SparkCatalog use a case sensitive CachingCatalog by default. #7535
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szehon-ho
approved these changes
May 5, 2023
snazy
approved these changes
May 5, 2023
|
Thanks guys, merged. After discussion on #7535 i'm also open to add the Catalog method caseSensitive(), we can default to true there and then set it to false for Hive, if someone is interested? I guess it can be a separate pr as there may be more discussion needed |
manisin
pushed a commit
to Snowflake-Labs/iceberg
that referenced
this pull request
May 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #7469.
To avoid breaking Spark users of Nessie, restore the former default behavior.
The case sensitivity of the CachingCatalog that wraps the SparkCatalog is still configurable, but it defaults to true.