Core: Remove duplicate check for ManifestEntry.dataSequenceNumber() #7538
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When dropping ManifestEntry.sequenceNumber in apache#6274, a new assert was added to validateManifest() and validateDeleteManifest(). However, there was a same assert already. Dropping one of them.
gaborkaszab
force-pushed
the
remove_duplicate_assert
branch
from
bda695d
to
2152fd6
Compare
aokolnychyi
approved these changes
May 5, 2023
|
Thanks, @gaborkaszab! I added the original check to make sure the deprecated behavior was tested but it is no longer needed. |
manisin
pushed a commit
to Snowflake-Labs/iceberg
that referenced
this pull request
May 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When dropping ManifestEntry.sequenceNumber in #6274, a new assert was added to TableTestBase.validateManifests(). However, there was a same assert already. Dropping one of them.