Core, AWS: Add flag to control whether initialization stack trace should be created in S3FileIO #7552
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…uld be created in S3FileIO When `S3FileIO` gets created through `ResolvingFileIO` then the creation stack trace is being kept in `ResolvingFileIO`. `ResolvingFileIO` will then close the underlying `S3FileIO` when `ResolvingFileIO#finalize() gets called. Therefore we don't want to issue a `WARN` in `S3FileIO` in case `S3FileIO#finalize()` gets called before `ResolvingFileIO#finalize()`.
nastra
force-pushed
the
flag-for-init-stacktrace
branch
from
994c6c8
to
efc868d
Compare
rdblue
approved these changes
May 9, 2023
|
Thanks, @nastra! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
S3FileIOgets created throughResolvingFileIOthen the creation stacktrace is being kept in
ResolvingFileIO.ResolvingFileIOwill thenclose the underlying
S3FileIOwhenResolvingFileIO#finalize()getscalled. Therefore we don't want to issue a
WARNinS3FileIOin caseS3FileIO#finalize()gets called beforeResolvingFileIO#finalize().