Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Add identifier to each Markdown file under docs #7575

Merged
merged 1 commit into from
May 12, 2023

Conversation

nastra
Copy link
Contributor

@nastra nastra commented May 10, 2023

I noticed that https://iceberg.apache.org/docs/latest/spark-configuration/ isn't showing up under the Spark section because Spark's configuration page and the Table configuration page were both using title: "Configuration" and only the first one wins and shows up in the main menu under Docs.

In order to not cause such collisions with any other markdown files that show up in the main menu, I think the best approach is to define an identifier for each one of them.

See also https://gohugo.io/content-management/menus/#properties-front-matter for some additional details on Hugo's identifier and when it is required.

@github-actions github-actions bot added the docs label May 10, 2023
Copy link
Contributor

@Fokko Fokko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this makes sense to me

@nastra
Copy link
Contributor Author

nastra commented May 12, 2023

thanks for the reviews @Fokko and @singhpk234. I'll merge this so that we can ship it with 1.3.0

@nastra nastra merged commit cf082af into apache:master May 12, 2023
2 checks passed
@nastra nastra deleted the fix-docs branch May 12, 2023 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants