Add unique JDBC application identifier and user agent header #7580
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manisin
commented
May 15, 2023
snowflake/src/main/java/org/apache/iceberg/snowflake/SnowflakeCatalog.java
Outdated
Show resolved
Hide resolved
snowflake/src/main/java/org/apache/iceberg/snowflake/SnowflakeCatalog.java
Show resolved
Hide resolved
| private static final String APP_IDENTIFIER = "iceberg-snowflake-catalog"; | ||
|
|
||
| // Specifies the length of unique id for each catalog initialized session. Should be less than 32 |
There was a problem hiding this comment.
Can you provide an explanation as to why there is a limit? Also, I see below that you strip out the - characters, which would result in a 32 char string, so why further reduce it to 20 chars which compromises the uniqueness guarantees?
There was a problem hiding this comment.
The application id is restricted to 50 characters by the JDBC driver so we need to trim the guid suffix. This does reduce the overall uniqueness but still provides enough uniqueness for our scenario where we want to correlate telemetry in a given time window. I have added comments in the code to clarify.
snowflake/src/main/java/org/apache/iceberg/snowflake/SnowflakeCatalog.java
Outdated
Show resolved
Hide resolved
danielcweeks
approved these changes
May 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the JDBC application identifier unique for each catalog initialization and add another JDBC property to include the application identifier in the JDBC web request's user agent header.
Also updating to the latest version of snowflake's JDBC driver.
This PR is continued from #7176 due to a bad git rebase.